e2e: add pod/container info in error form exec in pod. #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyp1ckles
force-pushed
the
pr/tp/improve-exec-errors
branch
from
d1ad966 to
5427e25
Compare
nathanjsweet
approved these changes
Nov 10, 2023
|
/test |
|
Closed and re-opened PR to retrigger all tests. They were failing because of the GH incident last week. |
|
@tommyp1ckles Could we get this PR? 🙏 |
When running connectivity tests, it's up to debug logs to provide information on failure errors. This is not always the case, making it hard to understand where to start investigating errors. This adds pod/container to the error message for calls to k8s exec to make it easier to understand where the issue occured. Signed-off-by: Tom Hadlaw <[email protected]>
tommyp1ckles
force-pushed
the
pr/tp/improve-exec-errors
branch
from
5427e25 to
b9a93b8
Compare
tklauser
approved these changes
Nov 23, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running connectivity tests, it's up to debug logs to provide information on failure errors. This is not always the case, making it hard to understand where to start investigating errors.
This adds pod/container to the error message for calls to k8s exec to make it easier to understand where the issue occurred.
Ex use case:
Running test echo-ingress-l7-named-port: setting up test: applying network policies: policies were not applied on all Cilium nodes in time: Timeout occurredRaises the questions: